Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.31] patch func deploy task for serverless 1.31.1 #737

Conversation

serverless-qe
Copy link

patch for func-deploy task to use midstream specific client built for 1.31.1

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.31@a2b1047). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.31     #737   +/-   ##
==================================================
  Coverage                   ?   39.01%           
==================================================
  Files                      ?      106           
  Lines                      ?    13833           
  Branches                   ?        0           
==================================================
  Hits                       ?     5397           
  Misses                     ?     7712           
  Partials                   ?      724           
Flag Coverage Δ
e2e-test 36.47% <0.00%> (?)
e2e-test-oncluster-runtime 25.60% <0.00%> (?)
e2e-test-runtime-go 25.92% <0.00%> (?)
e2e-test-runtime-node 26.92% <0.00%> (?)
e2e-test-runtime-python 26.92% <0.00%> (?)
e2e-test-runtime-quarkus 27.03% <0.00%> (?)
e2e-test-runtime-rust 25.92% <0.00%> (?)
e2e-test-runtime-springboot 26.06% <0.00%> (?)
e2e-test-runtime-typescript 27.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Collaborator

/override "Func E2E OnCluster Test / On Cluster Test (1.20.2, ubuntu-latest)"
/override "Func Integration Test / Integration Test (1.20.2, ubuntu-latest)"
/override "Func Unit Test / Unit Test (1.20.2, 17, ubuntu-latest)"

Copy link

openshift-ci bot commented Feb 7, 2024

@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Func E2E OnCluster Test / On Cluster Test (1.20.2, ubuntu-latest)
  • Func Integration Test / Integration Test (1.20.2, ubuntu-latest)
  • Func Unit Test / Unit Test (1.20.2, 17, ubuntu-latest)

Only the following failed contexts/checkruns were expected:

  • E2E Test (1.20.2, ubuntu-latest)
  • E2E Test (node)
  • E2E Test (python)
  • E2E Test (quarkus)
  • Integration Test (1.20.2, ubuntu-latest)
  • On Cluster RT Test (1.20.2, ubuntu-latest, s2i)
  • On Cluster Test (1.20.2, ubuntu-latest)
  • Unit Test (1.20.2, 17, macos-latest)
  • Unit Test (1.20.2, 17, ubuntu-latest)
  • Unit Test (1.20.2, 17, windows-latest)
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Func E2E OnCluster Test / On Cluster Test (1.20.2, ubuntu-latest)"
/override "Func Integration Test / Integration Test (1.20.2, ubuntu-latest)"
/override "Func Unit Test / Unit Test (1.20.2, 17, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Collaborator

/override "On Cluster Test (1.20.2, ubuntu-latest)"
/override "Integration Test (1.20.2, ubuntu-latest)"
/override "Unit Test (1.20.2, 17, ubuntu-latest)"

Copy link

openshift-ci bot commented Feb 7, 2024

@matejvasek: Overrode contexts on behalf of matejvasek: Integration Test (1.20.2, ubuntu-latest), On Cluster Test (1.20.2, ubuntu-latest), Unit Test (1.20.2, 17, ubuntu-latest)

In response to this:

/override "On Cluster Test (1.20.2, ubuntu-latest)"
/override "Integration Test (1.20.2, ubuntu-latest)"
/override "Unit Test (1.20.2, 17, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2024
Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, serverless-qe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jrangelramos
Copy link

new PR sent for this one #743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants